New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: refine e2e test scripts #10918
Conversation
@@ -5,7 +5,7 @@ | |||
#==============================================================================# | |||
|
|||
# Start in scripts/integration-tests/ even if run from root directory | |||
cd "$(dirname "$0")" | |||
cd "$(dirname "$0")" || exit |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -25,7 +25,7 @@ startLocalRegistry "$PWD"/../../verdaccio-config.yml | |||
yarn install | |||
# "yarn upgrade --scope @babel --latest" doesn't seem to work. | |||
# a means "all", while \n is the enter needed to confirm the selection. | |||
echo "a\n" | yarn upgrade-interactive --scope @babel --latest | |||
printf "a\n" | yarn upgrade-interactive --scope @babel --latest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we run shellcheck while linting? |
@nicolo-ribaudo Sure. But I can add an optional |
Yeah making it optional sounds good. But if this PR is blocking the other one, let's do it in a separate PR. |
-j
to make commands.--depth=1
to git clone.